chore: have a better error message when context bounds are not allowed #23190
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
force-pushed
the
i22660
branch
2 times, most recently
from
47a1d04 to
f95ae7e
Compare
Co-authored-by: ajafri2001 <[email protected]> Co-authored-by: jan-pieter <[email protected]>
| val bounds = typeAndCtxBounds(name) | ||
| val res = bounds match | ||
| case bounds: ContextBounds if paramOwner.acceptsCtxBounds => | ||
| TypeDef(name, lambdaAbstract(hkparams, bounds)).withMods(mods) |
There was a problem hiding this comment.
Can you try getting rid of these repetitions? It seems to me that assigning the result is orthogonal to checking the correctness of context bounds. Could you maybe extract the error checking logic to a different function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22660